fix: Subsonic: Allow user to force player provider seek #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khers
changed the title
Some Subsonic implementations advertise the ability to specify an offset when calling the stream endpoint. This offset should allow a user to seek by setting that value, however, at least on Gonic this value is only honored with transcoding. Allow a user to tell the subsonic provider that their server is broken and provider seek should be used instead. Fixes: music-assistant/hass-music-assistant#3184 Signed-off-by: Eric B Munson <eric@munsonfam.org>
khers
force-pushed
the
seek-switch
branch
2 times, most recently
from
816f982 to
bdc16ae
Compare
marcelveldt
approved these changes
Dec 4, 2024
|
@khers fix not working for me (and not only me) after enabling the new option in subsonic provider, see last comments for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Subsonic implementations advertise the ability to specify an offset when calling the stream endpoint. This offset should allow a user to seek by setting that value, however, at least on Gonic this value is only honored with transcoding. Allow a user to tell the subsonic provider that their server is broken and provider seek should be used instead.
Fixes: music-assistant/hass-music-assistant#3184