Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Modal] Add migration guide and codemod for deprecated props #45021

Merged
merged 4 commits into from
Jan 15, 2025
Merged

[material-ui][Modal] Add migration guide and codemod for deprecated props #45021

merged 4 commits into from
Jan 15, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jan 14, 2025 •
edited
Loading

part of #41281

BackdropComponent and BackdropProps are already deprecated, this PR just adds migration guide and codemod

material-ui/packages/mui-material/src/Modal/Modal.d.ts

Line 32 in 093d4f3

* @deprecated Use `slots.backdrop` instead. While this prop currently works, it will be removed in the next major version.

material-ui/packages/mui-material/src/Modal/Modal.d.ts

Line 47 in 093d4f3

* @deprecated Use `slotProps.backdrop` instead.

@sai6855 sai6855 added component: modal This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material labels Jan 14, 2025
@sai6855 sai6855 changed the title [material-ui][Modal] add migration guide and codemod [material-ui][Modal] Add migration guide and codemod Jan 14, 2025
@mui-bot
Copy link

mui-bot commented Jan 14, 2025 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against de370b2

@sai6855 sai6855 requested a review from siriwatknp January 14, 2025 07:18
@sai6855 sai6855 changed the title [material-ui][Modal] Add migration guide and codemod [material-ui][Modal] Add migration guide and codemod for deprecated props Jan 14, 2025
siriwatknp
siriwatknp approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sai6855 sai6855 mentioned this pull request Jan 13, 2025
Open
36 tasks
@sai6855 sai6855 merged commit 767c2a4 into mui:master Jan 15, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: modal This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @siriwatknp