Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix TOC highlighting logic #29435

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 31, 2021

Since #29204, it's no longer possible to reach this highlight state by scrolling;

Screenshot 2021-10-31 at 18 02 29

https://master--material-ui.netlify.app/components/autocomplete/#customized-hook

This reverts commit 6b12d46, to fix the regression it introduces. I propose we either ignore the case (we don't use the React streaming feature, and we might never do) or have a deeper look into how to fix the issue.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Oct 31, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 31, 2021

No bundle size changes

Generated by 🚫 dangerJS against 0101982

@mnajdova mnajdova merged commit 2a839d3 into mui:master Nov 1, 2021
@oliviertassinari oliviertassinari deleted the fix-toc-detection branch November 1, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants