Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputBase] Remove WebkitAppearance from search type #29383

Merged
merged 1 commit into from
Nov 8, 2021
Merged

[InputBase] Remove WebkitAppearance from search type #29383

merged 1 commit into from
Nov 8, 2021

Conversation

nicbarajas
Copy link
Contributor

On Safari for iOS 15.1, the appearance of text fields has a background color which is being shown on the search input type. This removes the appearance from the base styles so it no longer attempts to display a background.

Closes #29365

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 29, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against b06a38e

@michaldudak michaldudak added the component: text field This is the name of the generic UI component, not the React module! label Nov 8, 2021
michaldudak
michaldudak approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't noticed any regression on older devices, so it's good to go. Thanks for your work!

@michaldudak michaldudak merged commit 68b21b0 into mui:master Nov 8, 2021
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Nov 10, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 10, 2021 •
edited
Loading

I was not able to reproduce the issue. Does anyone have a screenshot of the issue? I could test up to iOS 15.0. Is it a regression from iOS 15.1?

I went on a search hunt, the code was added in 8e2714b, so unclear. If it was really needed, we will know from feedback from the developers.

@nicbarajas
Copy link
Contributor Author

nicbarajas commented Nov 10, 2021 •
edited by oliviertassinari
Loading

Does anyone have a screenshot of the issue?

Here you go, from the CodeSandbox I created:

I'm not sure I can answer your other question but I noticed it on a project only recently and after I upgraded to 15.1, so I couldn't test again aft earlier versions.

@michaldudak
Copy link
Member

@oliviertassinari I was able to reproduce it on 15.1. I then tested it after the fix on iOS 14 and on desktop Safari 14 (the earliest we support). I haven't noticed any unexpected outcome.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 10, 2021 •
edited
Loading

OK awesome, I wanted to make sure we have breadcrumbs (version + visual illustration + reproduction) in case we need, in 5 years, to come back to it. We didn't have them with 8e2714b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OutlinedInput receives background on search inputs on iOS
4 participants
@nicbarajas @mui-pr-bot @oliviertassinari @michaldudak