Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CalendarPicker] Fix slide transition regression #27273

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 14, 2021

Regressed in #27043

Preview: https://deploy-preview-27273--material-ui.netlify.app/components/date-picker/#landscape-orientation

Changelog entry can be ignored if we have no release between #27043 and now

@eps1lon eps1lon added bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! labels Jul 14, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 14, 2021

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 3c56aa3

@eps1lon eps1lon marked this pull request as ready for review July 14, 2021 13:00
@eps1lon eps1lon requested a review from oliviertassinari July 14, 2021 13:00
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation looks much better now, thanks.

I have noticed something else linked to #27043 that might have changed (at least on my phone). It seems that this demo https://next.material-ui.com/components/date-picker/#static-mode used to be rendering its content with JavaScript disabled, it's not longer the case after #27043. I will provide more details later on. It might not even matter.

@eps1lon eps1lon merged commit a3144a4 into mui:next Jul 14, 2021
@eps1lon eps1lon deleted the fix/pickers/transition branch July 14, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants