[examples] Update create-react-app examples #13453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <meta name="viewport" content="minimum-scale=1, initial-scale=1, width=device-width, shrink-to-fit=no"> | ||
| <!-- PWA primary color --> | ||
| <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> |
There was a problem hiding this comment.
minimum-scale=1 is important for GPU rasterization.
There was a problem hiding this comment.
Was this manually added or previously default in create-react-app?
oliviertassinari
changed the title
Includes basic output when running `yarn create react-app`
eps1lon
changed the title
cra has its own rules anyway
oliviertassinari
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
create-react-appexamples to be as close to the standard output fromyarn create react-app --typescriptas possible. This includes:react-scriptsfor ts example thanks to TypeScript support using Babel 7 facebook/create-react-app#4837Sandboxes: