[docs-infra] Remove rehypeEmptyLines
#1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
aarongarciah
approved these changes
Dec 22, 2024
oliviertassinari
changed the title
rehypeEmptyLinesrehypeEmptyLines
| @@ -1,6 +1,5 @@ | |||
| import { createHighlighter } from 'shiki'; | |||
| import rehypePrettyCode from 'rehype-pretty-code'; | |||
| import { rehypeEmptyLines } from './rehypeEmptyLines.mjs'; | |||
There was a problem hiding this comment.
So, we should delete this file too? rehypeEmptyLines.mjs is orphan now?
There was a problem hiding this comment.
It has some purpose, but I'm not sure what - Vlad knows. I kept it in case it'll be re-added soon with a fixed implementation. Since git history keeps it here, it's not crucial to be kept around though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1211. Not sure what this is for but it's breaking the code blocks.
Before: https://deploy-preview-1210--base-ui.netlify.app/react/handbook/composition
After: https://deploy-preview-1212--base-ui.netlify.app/react/handbook/composition
