Add support for multi volume 7z files #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskowronek
reviewed
Jul 1, 2023
...n/java/com/mucommander/sevenzipjbindings/multivolume/SevenZipMultiVolumeCallbackHandler.java
Outdated
Show resolved
Hide resolved
pskowronek
reviewed
Jul 1, 2023
|
|
||
| @Override | ||
| public String cryptoGetTextPassword() throws SevenZipException { | ||
| if (password == null) { |
There was a problem hiding this comment.
how about empty password? how is it being treated - just being curious....
There was a problem hiding this comment.
Interesting question... I don't think it is technically possible to encrypt with an empty password because essentially you don't have a key to perform the encryption operation in the first place...
pskowronek
reviewed
Jul 1, 2023
...n/java/com/mucommander/sevenzipjbindings/multivolume/SevenZipMultiVolumeCallbackHandler.java
Show resolved
Hide resolved
ahadas
reviewed
Jul 1, 2023
...jbindings/src/main/java/com/mucommander/sevenzipjbindings/SevenZipJBindingROArchiveFile.java
Outdated
Show resolved
Hide resolved
...n/java/com/mucommander/sevenzipjbindings/multivolume/SevenZipMultiVolumeCallbackHandler.java
Outdated
Show resolved
Hide resolved
...n/java/com/mucommander/sevenzipjbindings/multivolume/SevenZipMultiVolumeCallbackHandler.java
Outdated
Show resolved
Hide resolved
...n/java/com/mucommander/sevenzipjbindings/multivolume/SevenZipMultiVolumeCallbackHandler.java
Outdated
Show resolved
Hide resolved
...n/java/com/mucommander/sevenzipjbindings/multivolume/SevenZipMultiVolumeCallbackHandler.java
Outdated
Show resolved
Hide resolved
...n/java/com/mucommander/sevenzipjbindings/multivolume/SevenZipMultiVolumeCallbackHandler.java
Show resolved
Hide resolved
…to multi_volume_7z
ahadas
approved these changes
Jul 6, 2023
|
thanks @ShayArtzi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I would like to finish the multi-volume archive support I have started in PR #881. This PR is for adding support for multi volume 7z archives.
Multi volume 7z archives have a special file extension -
7z.DDDwhereDDDis a 3-digit number, starting with001:Internally, multi-part 7z files are just a 7z file split into multiple files. It means that:
This is different from the way multi volume rar files are implemented, and that's the reason why I have created a dedicated handler for multi volume 7z files (and didn't re-use the multi volume rar handler).
Please let me know what you think... Thanks!