Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal - fix for themes switching, Menlo font added as default for Terminal #978

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Terminal - fix for themes switching, Menlo font added as default for Terminal #978

merged 2 commits into from
Jun 27, 2023

Conversation

pskowronek
Copy link
Member

@pskowronek pskowronek commented Jun 9, 2023 •
edited
Loading

  1. fix for themes switching (regression after Shell history removal - NPE in logs causing theme not being applied dynamically)
  2. Menlo font added as a default for Terminal for all themes (even native one, apparently on macOS font for TextArea.font (via UIManager) is Lucida grande that looks bad (and is not mono-spaced) - [Enhancement] Use Menlo instead of Lucida Grande as default font in Terminal on macOS #976.

@pskowronek pskowronek requested a review from ahadas as a code owner June 9, 2023 17:23
@pskowronek pskowronek mentioned this pull request Jun 9, 2023
Closed
@ahadas ahadas linked an issue Jun 26, 2023 that may be closed by this pull request
[Enhancement] Use Menlo instead of Lucida Grande as default font in Terminal on macOS #976
Closed
@ahadas
Copy link
Member

ahadas commented Jun 26, 2023

  1. Menlo font added as a default for Terminal for all themes (even native one, apparently on macOS font for TextArea.font (via UIManager) is Lucida grande that looks bad (and is not mono-spaced) - [Enhancement] Use Menlo instead of Lucida Grande as default font in Terminal on macOS #976.

@pskowronek please document this in the readme.txt file

@pskowronek
Copy link
Member Author

PR updated

@ahadas ahadas merged commit 04c8899 into mucommander:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Use Menlo instead of Lucida Grande as default font in Terminal on macOS
2 participants
@pskowronek @ahadas