Fix for DE keyboard layout #933 #935
Conversation
pskowronek
changed the title
pskowronek
changed the title
mucommander-preferences/src/main/java/com/mucommander/conf/MuPreferences.java
Outdated
Show resolved
Hide resolved
mucommander-core/src/main/java/com/mucommander/ui/terminal/TerminalWindow.java
Outdated
Show resolved
Hide resolved
|
PR updated with 1st comment. |
|
|
||
| @Override | ||
| public void configurationChanged(ConfigurationEvent event) { | ||
| if (MuPreference.USE_OPTION_AS_META_KEY.equals( |
There was a problem hiding this comment.
how about checking if that's the configuration that has changed without iterating the values of MuPreference by
| if (MuPreference.USE_OPTION_AS_META_KEY.equals( | |
| if (MuPreferences.USE_OPTION_AS_META_KEY.equals(event.getVariable())) { |
There was a problem hiding this comment.
I don't like to operate on strings if we can use enums.... I would rather say that MuPreferences should be refactored to be enums, too.
There was a problem hiding this comment.
ok, in my opinion it's alright to use strings now that we can use them in switch-case but that's a matter of taste
I don't mind having an extra step of getting the enum from the label here but we can do it more efficiently - I'll post a separate cleanup
|
|
||
| @Override | ||
| public void configurationChanged(ConfigurationEvent event) { | ||
| if (MuPreference.USE_OPTION_AS_META_KEY.equals( |
There was a problem hiding this comment.
ok, in my opinion it's alright to use strings now that we can use them in switch-case but that's a matter of taste
I don't mind having an extra step of getting the enum from the label here but we can do it more efficiently - I'll post a separate cleanup
Fix for DE (and some others) keyboard layout: #933
Added preference option (which is by default
false):