Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer/Editor Fixes for #825 and #824 #830

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

pskowronek
Copy link
Member

Fixes for:

Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pskowronek functionality wise, it was good but I've posted another commit to replace the method with FileterInputSream and replaced the AtomicBoolean with an array, what do you think?

@pskowronek
Copy link
Member Author

@pskowronek functionality wise, it was good but I've posted another commit to replace the method with FileterInputSream and replaced the AtomicBoolean with an array, what do you think?

I saw it :)

  • FileterInputSream - good
  • AtomicBoolean -> array - a matter of taste I would say (I prefer AtomicBoolean way)
  • inline override FileterInputSream directly inside startEditing method - again a matter of taste (I like doing that via additional method to have cleaner code)

But overall, it is OK

Copy link
Member Author

@pskowronek pskowronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented in the conversation.
BTW, I cannot approve as github forbids me to approve 'my own PR' :)

@ahadas
Copy link
Member

ahadas commented Jan 3, 2023

BTW, I cannot approve as github forbids me to approve 'my own PR' :)

yeah, I'm aware of that, that's ok :)
and I've replaced the boolean array with AtomicBoolean, I wasn't sure if I like that as well..

@ahadas ahadas merged commit 990ebf2 into mucommander:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants