Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore timestamp of parent directory after file deleting #774

Merged
merged 3 commits into from
Oct 30, 2022

Conversation

mfilser
Copy link
Contributor

@mfilser mfilser commented Oct 15, 2022

Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfilser thanks for posting this!
in general, I believe we should operate as close as possible to what system tools would do, in this case mv. so when I read the issue you described in #720, it made sense to me that we should do as you say, i.e., preserve the original modification date of target directories when they move to a different file system (partition). but when I looked at this PR it took me time to figure out why you've changed the modification date of the source folders and now I see - we use cached files so by doing that, the date of the source folder is retrieved before it changes later on when removing its children. so let me post an alternative way to achieve this and then see if that also resolves the issue

@ahadas ahadas force-pushed the mv_directories_keep_timestamp branch from 36eb251 to b1bcd39 Compare October 29, 2022 09:34
@ahadas
Copy link
Member

ahadas commented Oct 29, 2022

@mfilser can you please take a look at this commit and let me know what you think?

@mfilser
Copy link
Contributor Author

mfilser commented Oct 30, 2022

@ahadas
Thank you for the feedback.
Your commit 7f23021 works very well too, i tested it right now and the issue is still resolved.

@ahadas
Copy link
Member

ahadas commented Oct 30, 2022

thanks for the confirmation!

@ahadas ahadas merged commit dfb72df into mucommander:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep directory timestamp when moving between different mountpoints
2 participants