Added -PskipDmgSign param for dmg task, readme.md updated/refreshed #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahadas
reviewed
Jul 2, 2024
| ``` | ||
| ./gradlew dmg | ||
| ./gradlew clean dmg -PskipDmgSign |
There was a problem hiding this comment.
but the clean task is not required for this, why adding it here and below?
There was a problem hiding this comment.
I have impression that changes may not be properly included in DMG (if bundles were built before the change). And, additionally, jpackage complains that .app already exists:
build/muCommander.app already exists
at jdk.jpackage/jdk.jpackage.internal.AppImageBundler.createRoot(AppImageBundler.java:155)
at jdk.jpackage/jdk.jpackage.internal.AppImageBundler.createAppBundle(AppImageBundler.java:174)
at jdk.jpackage/jdk.jpackage.internal.AppImageBundler.execute(AppImageBundler.java:91)
at jdk.jpackage/jdk.jpackage.internal.Arguments.generateBundle(Arguments.java:700)
at jdk.jpackage/jdk.jpackage.internal.Arguments.processArguments(Arguments.java:565)
at jdk.jpackage/jdk.jpackage.main.Main.execute(Main.java:92)
at jdk.jpackage/jdk.jpackage.main.Main.main(Main.java:53)
But the real reason was to be sure that recent changes are there.
Co-authored-by: Arik Hadas <arik.hadas1@gmail.com>
ahadas
approved these changes
Jul 2, 2024
| ``` | ||
| ./gradlew dmg | ||
| ./gradlew clean dmg -PskipDmgSign |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dmgtask (for dev purposes) + readme.md updated for it