Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink the size of jediterm fat-jar #1067

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Shrink the size of jediterm fat-jar #1067

merged 1 commit into from
Sep 25, 2023

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Sep 25, 2023

No description provided.

@ahadas ahadas requested a review from pskowronek September 25, 2023 15:18
pskowronek
pskowronek reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@pskowronek pskowronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shy question - how come this made jar smaller?

@ahadas
Copy link
Member Author

ahadas commented Sep 25, 2023 •
edited
Loading

@pskowronek, now that microsoft-graph also brings kotlin libraries - using their bundles instead of bundling those libraries into the jar of jediterm reduces the size of the jar. the same goes for guava and jna, but those existed as separate bundles before adding microsoft-graph

pskowronek
pskowronek approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@pskowronek pskowronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ahadas ahadas merged commit 5dbe9e8 into mucommander:master Sep 25, 2023
@ahadas ahadas deleted the shrink_jediterm branch September 25, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pskowronek pskowronek pskowronek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahadas @pskowronek