muC faster start up #1044

pskowronek · 2023-08-15T14:31:52Z

tweaked how bundles are being loaded (added parallelized bundle loading and deferring) - this gave 2-3 times faster bundle loading etc (from 2-3s to ~400-800ms)
added java params for to start faster: -XX:+TieredCompilation -XX:TieredStopAtLevel=1 - these gave quite a lot of boost (https://stackoverflow.com/a/46516509/1715521)
further defer Bonjour loading (let JmDNSImpl start later to let muC have resources for start up)
muCommander.java - parallelized loading of configurations
replaced all imports swing.* and awt.* in java - this gave almost no speed effect
SMB activator moved to background (sb needs to check if it works - this never worked for me)
theme loader - replaced all ladder IFs with switches (hence code compatibility set to 20) - done automagically by Idea (refactor)
enabling Notifications moved to background (as it also took some time)
loading icons used .getResource two times
LaFs loading was taking long - additional LaFs are being loaded in background (unless they are chosen by the user)
Clipboard check is done on start up, sometimes it caused delay if something unsupported by muC was there (like code copied from Idea, this caused 'class not found' exceptions) - to be addressed here: [Bug] Checking clipboard state on startup can delay overall launch time #1137
ADB menu deferred, Bonjour init also moved after start
Quick list loaded in background
Pre-load JFrame and couple of JPanels as early as possible and then use it Application for MainFrame etc
Pre-load all fonts into JVM - this is very slow, at least on macs - start loading fonts in background even before felix is initiated (this may yield caching fonts done in a previous commit unnecessary)

Those changes make loading times 2-3 faster (3s->1s on Andreas' mac, on my mac from 6-7s->~2.6-3s).

Remarks:

it seems that splash screen loading adds 100-200ms to startup time on my mac (this can be turned off in Preferences)
What's left is:
the time of loading/initializing JVM - not sure if something could be done about it more (@ahadas )
think about loding bundles for extensions/plugins when main app started (akin how Idea or Eclipse does it).

...mander-protocol-adb/src/main/java/com/mucommander/commons/file/protocol/adb/AndroidMenu.java

ahadas · 2023-08-15T18:44:19Z

btw, I've spotted that hamcrest-core bundle is being loaded? Why?

junit drags it:

+--- project :mucommander-protocol-registry
|    +--- project :mucommander-commons-file (*)
|    +--- project :mucommander-commons-util (*)
|    +--- project :mucommander-protocol-api (*)
|    +--- project :mucommander-format-gzip (*)
|    +--- project :mucommander-process (*)
|    +--- project :mucommander-translator (*)
|    +--- org.slf4j:slf4j-api:1.7.36
|    +--- org.osgi:osgi.core:8.0.0
|    +--- org.ovirt.engine.api:sdk:4.4.5
|    |    +--- org.slf4j:slf4j-api:1.7.7 -> 1.7.36
|    |    +--- com.fasterxml.jackson.core:jackson-databind:2.10.0
|    |    |    +--- com.fasterxml.jackson.core:jackson-annotations:2.10.0
|    |    |    \--- com.fasterxml.jackson.core:jackson-core:2.10.0
|    |    +--- org.apache.httpcomponents:httpclient:4.5 (*)
|    |    \--- org.apache.httpcomponents:httpcore:4.4.1
|    \--- com.googlecode.json-simple:json-simple:1.1.1
|         \--- junit:junit:4.10
|              \--- org.hamcrest:hamcrest-core:1.1

pskowronek · 2023-08-15T21:12:09Z

btw, I've spotted that hamcrest-core bundle is being loaded? Why?

junit drags it:

any hint where to add exclusion?

pskowronek · 2023-08-15T21:13:55Z

PR updated to address: #492 (comment)

pskowronek · 2023-08-17T18:42:19Z

PR updated - faster UI start up.

pskowronek · 2023-08-26T10:19:48Z

@ahadas - this PR is more PoC, but - in one of the recent commits I've switched code compatibility to java 20 - I guess this broke tests here? ./gradlew clean test locally works for me.

pskowronek · 2023-09-05T22:00:09Z

@ahadas - I tried to commit each attempt/idea in a separate commit. Some ideas were removed in subsequent commits (try & error), but overall I think all commits bring some benefit. Font caching is disputable, however I would keep it (it seems that on my mac it saves ~100ms if/when fonts are pre-loaded on time). Since a lot of concurrency has been introduced it requires a lot of testing on different platforms. From my side, occasionally, 1 time I've spotted a problem when action menu bar was not displayed (right now I cannot reproduce that, but I think there's a race condition), plus rarely I get Cannot invoke "javax.swing.JButton.setToolTipText(String)" because "oneTouchButton" is null.

Nevertheless, tell me what you think about it, should be continue this, or not.

ahadas · 2023-09-09T16:37:45Z

@ahadas - I tried to commit each attempt/idea in a separate commit. Some ideas were removed in subsequent commits (try & error), but overall I think all commits bring some benefit. Font caching is disputable, however I would keep it (it seems that on my mac it saves ~100ms if/when fonts are pre-loaded on time). Since a lot of concurrency has been introduced it requires a lot of testing on different platforms. From my side, occasionally, 1 time I've spotted a problem when action menu bar was not displayed (right now I cannot reproduce that, but I think there's a race condition), plus rarely I get Cannot invoke "javax.swing.JButton.setToolTipText(String)" because "oneTouchButton" is null.

Nevertheless, tell me what you think about it, should be continue this, or not.

@pskowronek thanks for the effort you've put on this! I was not able to follow the changes closely recently but I read your conversation with @Andreas0602 and it seems you've managed to accelerate the startup time nicely. there are quite a few changes here so it can take me some time to review them but as I want to release 1.4.0 soon, I'll try to provide feedback shortly

src/main/java/com/mucommander/main/AutoProcessor.java

ahadas · 2023-09-16T09:30:12Z

src/main/java/com/mucommander/main/AutoProcessor.java

+                        var jarPath = jarFile.toURI().toString();
+                        if (jarPath.contains("dropbox") || jarPath.contains("jediterm")
+                                || jarPath.contains("protocol-gcs") || jarPath.contains("viewer-pdf")
+                                || jarPath.contains("gdrive")) {


that's not that great.. what's the reason for this?

yes, it's not, I agree. Those bundles are relatively big and not required as the first ones. We may introduce sth like checking bundle size, and defer the biggest ones.

I'm ok with using several threads to load the bundles but we need to ensure that the protocol and format bundles are loaded before mucommander-core is loaded as we may have an initial location that requires them

I may try to drop this deferring and see how it impacts the load time.

I may try to drop this deferring and see how it impacts the load time.

in my tests, I didn't see an issue with deferring gdrive even when I had my google drive loaded on startup but @pskowronek did you check the above?

@ahadas - I would keep that "deffering", i.e. to start them as the last ones so they have more time to load (these are the biggest jars/bundles). In a couple of minutes I will provide commit - I moved those names to a separate global variable with some explanation.

Turning off 'defer' adds ~200ms delay - these measures were done by running both versions a couple of times. With defer, the quickest load of bundles was around 1.5s on my machine, avg 1.6s, whereas for no-defer version, it was rather 1.8s on avg. Again, this observation might be only relevant on my macbook - maybe on newer macbooks both results might be the same or negligible.

src/main/java/com/mucommander/main/AutoProcessor.java

mucommander-bonjour/src/main/java/com/mucommander/bonjour/BonjourDirectory.java

mucommander-core/src/main/java/com/mucommander/ui/main/SplashScreen.java

ahadas · 2023-09-16T09:56:16Z

@pskowronek that's a very partial review - I'm also in the process of trying to extract unrelated changes to make it easier to review

build.gradle

mucommander-core/src/main/java/com/mucommander/Application.java

mucommander-core/src/main/java/com/mucommander/ui/main/SplashScreen.java

mucommander-core-preload/src/main/java/com/mucommander/preload/PreloadedJFrame.java

mucommander-translator/src/main/resources/dictionary.properties

pskowronek · 2023-09-16T21:22:48Z

PR updated with review comments (and rebased)

pskowronek · 2023-09-17T14:37:40Z

@ahadas - another PR update, dirty fix for tests - let's think where to 'initialize' PreloadedJFrame (OsVersion wasn't meant to be the final place :) ).

… background - fix for ISE

… background - fix for ISE2

…ad deferred, no clipboard check on start

…nough

…tlns

pskowronek · 2024-04-23T18:01:15Z

@pskowronek looks great now, a minor comment inside please update the title and description of the PR, and document the change in the readme file

PR updated!

ahadas

@pskowronek thanks!

pskowronek requested a review from ahadas as a code owner August 15, 2023 14:31

pskowronek commented Aug 15, 2023

View reviewed changes

...mander-protocol-adb/src/main/java/com/mucommander/commons/file/protocol/adb/AndroidMenu.java Outdated Show resolved Hide resolved

Andreas0602 mentioned this pull request Aug 15, 2023

muCommander startup was faster with OSX 10.11 and muCommander 0.9.0 #492

Closed

pskowronek force-pushed the faster_start branch from 1582683 to ce2a4da Compare August 15, 2023 21:10

pskowronek force-pushed the faster_start branch from 544506a to d157fe2 Compare August 26, 2023 10:05

pskowronek force-pushed the faster_start branch from 0963f98 to 8c7132f Compare August 27, 2023 16:24

pskowronek force-pushed the faster_start branch from 5ec410e to 2dd2c2c Compare September 13, 2023 20:59

ahadas mentioned this pull request Sep 16, 2023

CRLF -> LF #1054

Merged

ahadas force-pushed the faster_start branch from 2dd2c2c to 3b9da66 Compare September 16, 2023 08:54

ahadas reviewed Sep 16, 2023

View reviewed changes

ahadas force-pushed the faster_start branch 2 times, most recently from b46cb56 to 4bad0ff Compare September 16, 2023 10:18

ahadas reviewed Sep 16, 2023

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

mucommander-core/src/main/java/com/mucommander/Application.java Outdated Show resolved Hide resolved

ahadas force-pushed the faster_start branch from 4bad0ff to 954cb0d Compare September 16, 2023 10:31

ahadas reviewed Sep 16, 2023

View reviewed changes

mucommander-core/src/main/java/com/mucommander/ui/main/SplashScreen.java Show resolved Hide resolved

mucommander-core-preload/src/main/java/com/mucommander/preload/PreloadedJFrame.java Show resolved Hide resolved

ahadas force-pushed the faster_start branch from 954cb0d to ba7990c Compare September 16, 2023 10:58

ahadas reviewed Sep 16, 2023

View reviewed changes

mucommander-translator/src/main/resources/dictionary.properties Outdated Show resolved Hide resolved

pskowronek force-pushed the faster_start branch from ba7990c to fc3a630 Compare September 16, 2023 21:21

pskowronek force-pushed the faster_start branch from 039c5cc to ad887f8 Compare September 17, 2023 19:57

pskowronek mentioned this pull request Sep 19, 2023

Bonjour defer loading even more #1061

Merged

pskowronek added 24 commits April 23, 2024 19:36

Faster startup - font names cached in file, enabling notifications in…

e9a2113

… background - fix for ISE

Faster startup - font names cached in file, enabling notifications in…

8f61bae

… background - fix for ISE2

Faster startup - icon load optimized, LaF optimized and other LaFs lo…

e10e753

…ad deferred, no clipboard check on start

Faster startup - Configuration listeners made thread safe

8f465d7

Faster startup - adb and smb - better startup, android icon added

b5ac642

Faster startup - synchronized map

ba48dd3

Faster startup - init quick lists in background

224c425

Faster startup - pre-load JFrame in separate bundle

bd9e5e2

Faster startup - init fonts in main in bg, preload jpanels

9c0b054

Faster startup - after PR review

40dd1ef

Faster startup - theme loader (arrows switch to old switch)

a2f4949

Faster startup - adb: searching -> loading

121e8f0

Faster startup - java 20->11

0fd24e0

Faster startup - dirty workaround for tests

fb12705

Faster startup - SplashScreen use local variable and completable future

1375583

Faster startup - smaller fixes after review

ee5258b

Faster startup - fix/workaround for vertical split not ready

7e2cfec

Faster startup - smaller fixes after review

3aefda6

Faster startup - com.mucommander.preload as bundle with activator

46ee790

Faster startup - removed font caching, early preloading into JVM is e…

e04ac32

…nough

Faster startup - first round of fixes after review

ef87c1f

Faster startup - second round of fixes after review

d76e7b6

Faster startup - 3rd round of fixes after review - removed debug prin…

957e2f0

…tlns

Faster startup - clean up, java.scripting should be removed?

88cd240

pskowronek force-pushed the faster_start branch from 027fc62 to 88cd240 Compare April 23, 2024 17:39

pskowronek changed the title ~~[PoC] muC Faster start up~~ muC faster start up Apr 23, 2024

Faster startup - updated readme + minor fix after final review

0804693

ahadas approved these changes Apr 23, 2024

View reviewed changes

ahadas merged commit 4030191 into mucommander:master Apr 23, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

muC faster start up #1044

muC faster start up #1044

pskowronek commented Aug 15, 2023 •

edited

Loading

ahadas commented Aug 15, 2023

pskowronek commented Aug 15, 2023

pskowronek commented Aug 15, 2023

pskowronek commented Aug 17, 2023

pskowronek commented Aug 26, 2023

pskowronek commented Sep 5, 2023

ahadas commented Sep 9, 2023 •

edited

Loading

ahadas Sep 16, 2023

pskowronek Sep 16, 2023

ahadas Sep 17, 2023

pskowronek Sep 27, 2023

ahadas Apr 20, 2024 •

edited by pskowronek

Loading

ahadas commented Sep 16, 2023

pskowronek commented Sep 16, 2023

pskowronek commented Sep 17, 2023

pskowronek commented Apr 23, 2024

ahadas left a comment

muC faster start up #1044

muC faster start up #1044

Conversation

pskowronek commented Aug 15, 2023 • edited Loading

ahadas commented Aug 15, 2023

pskowronek commented Aug 15, 2023

pskowronek commented Aug 15, 2023

pskowronek commented Aug 17, 2023

pskowronek commented Aug 26, 2023

pskowronek commented Sep 5, 2023

ahadas commented Sep 9, 2023 • edited Loading

ahadas Sep 16, 2023

Choose a reason for hiding this comment

pskowronek Sep 16, 2023

Choose a reason for hiding this comment

ahadas Sep 17, 2023

Choose a reason for hiding this comment

pskowronek Sep 27, 2023

Choose a reason for hiding this comment

ahadas Apr 20, 2024 • edited by pskowronek Loading

Choose a reason for hiding this comment

ahadas commented Sep 16, 2023

pskowronek commented Sep 16, 2023

pskowronek commented Sep 17, 2023

pskowronek commented Apr 23, 2024

ahadas left a comment

Choose a reason for hiding this comment

pskowronek commented Aug 15, 2023 •

edited

Loading

ahadas commented Sep 9, 2023 •

edited

Loading

ahadas Apr 20, 2024 •

edited by pskowronek

Loading