changed mergeAudioBuffers to a function declaration to preserve the name... #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame during minification.
muaz-khan
added a commit
that referenced
this pull request
Feb 11, 2015
changed mergeAudioBuffers to a function declaration to preserve the name...
AndersDJohnson
pushed a commit
to AndersDJohnson/RecordRTC
that referenced
this pull request
Apr 8, 2019
AndersDJohnson
pushed a commit
to AndersDJohnson/RecordRTC
that referenced
this pull request
Apr 8, 2019
changed mergeAudioBuffers to a function declaration to preserve the name...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In Chrome RecordRTC.min.js I think has an issue with minification obscuring the function expression mergeAudioBuffers in StereoAudioRecorder.js. The minifier removes the mergeAudioBuffers from the function expression. Later when
'this.onmessage = function (e) {mergeAudioBuffers(e.data);}'
is called mergeAudioBuffers is not found I believe. In order to preserve 'mergeAudioBuffers' function name until it is called later it is converted to a function declaration and appealed to as _function.name in processWebWorker.
Here is an example using https://webrtcexperiment-webrtc.netdna-ssl.com/RecordRTC.min.js
http://jsfiddle.net/jimlowrey/m2ev2meh/
and the modification using an inlined version from my local machine.
http://jsfiddle.net/jimlowrey/xpLr508k/
Not sure if I should check in the resulting RecordRTC.js and RecordRTC.min.js.
Please let me know if you think this is the best way to go about this and if you want any more information.
Thanks for the awesome resource!