Updates imp import to importlib for compatibility with Python 3.12
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py. `imp` is no longer supported in python 3.12, causing a hard error when using Ubuntu 24.04 LTS, that uses this version natively.
xsdg
changed the title
imp import to importlib for compatibility with Python 3.12
|
Looks reasonable! In general, the PR title should be independently meaningful without needing to look up other references to make sense of it. Referring to related bugs in the PR description is sufficient. Also, specifically in github, if you use a statement like "fixes #464 " in the description (I don't know if it also works in comments or not), that will cause that bug to be automatically marked as fixed when the PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Fixes #464
What is changed
mkchromecast/tray_threading.pyrefers toimpthat is no longer supported in python 3.12. This has been changed toimportlib. Initial testing shows that it is working.