-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for playnite 9 #19
Conversation
sharkusmanch
commented
Sep 7, 2021
•
edited
Loading
edited
- Updated for SDK changes in Playnite 9 (SDK 6.0.0)
- A game can now have multiple platforms. For now, just use the first platform and don't backup if there is more than one platform. The current platform backup system will likely need to be reworked, but seemed out of scope for this PR.
- Added manifest file for new built-int add-on browser/installer https://github.com/JosefNemec/PlayniteAddonDatabase. Will submit a PR to add on repo when this is merged.
Hello, sorry for interfering in the PR but I gave it a quick read and have some advice:
|
Good catch, thanks. Done
Good catch, thanks. Done
Agreed, also gives a smaller diff in this case. Done.
The settings do work. I would like to keep the scope of this PR small. Given that the settings still work, I would prefer to leave as is for now. |
Sorry for the delay in looking at this! I've been a bit busy personally, but I'm going to make time to review this tonight or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor issue, but I can take care of it after the merge. Thanks for the PR! I'll get a release out ASAP for this.
return game.Tags != null && game.Tags.Any(x => x.Name == "ludusavi-skip"); | ||
return game.Tags != null | ||
&& game.Tags.Any(x => x.Name == "ludusavi-skip") | ||
&& game.Platforms.Count > 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be ||
because we always want to skip if it has the tag, even if it only has one platform.