This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
RTL major refactor #5055
Merged
RTL major refactor #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in case of RTL languages
This is the initial step in fixing mozilla-services#4261
ianb
previously requested changes
Oct 24, 2018
| @@ -70,7 +70,7 @@ | |||
| @keyframes slide-left { | |||
| 0% { | |||
| opacity: 0; | |||
| transform: translate3d(160px, 0, 0); | |||
| transform: translate3d(160px, 0, 0); // FIXME: RTL | |||
There was a problem hiding this comment.
Did you intend to leave the FIXME here?
There was a problem hiding this comment.
Actually yes.
My experience with CSS animation is not that good, so I was hoping to either learn some more in order to fix it better, or get help form the community.
In any case, I don't think it should stop the merge of this PR, since it only affects the on-boarding flow.
|
I'm not sure I resolved those package-lock conflicts correctly, but who can ever know? I'll try to regenerate them after this lands. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4261
Changes include:
dir="rtl"ordir="ltr"to<html>tag according to the browser languagedelete-shot-buttondialog, or correct position for the screenshots pagination.