Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

use only needed woff2 font files for core add-on #283

Merged
merged 2 commits into from
Jan 7, 2021
Merged

use only needed woff2 font files for core add-on #283

merged 2 commits into from
Jan 7, 2021

Conversation

hamilton
Copy link
Contributor

@hamilton hamilton commented Jan 5, 2021 •
edited by Dexterp37
Loading

Closes #275. This brings down the size of the xpi from 1.8mb to about 550kb.

Checklist for reviewer:

  • The description should reference a bug or github issue, if relevant.
  • There must be a CHANGELOG.md entry for any non-test change.
  • Any change to the NPM commands must be carefully reviewed to make sure it won't break the Add-ons pipeline.
  • Any version increase must follow the release process.

@hamilton hamilton requested a review from Dexterp37 January 5, 2021 20:14
Dexterp37
Dexterp37 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ - thanks for doing this. Please make sure that the addon packs without new warnings and that the generated file runs without problems in the browser before merging. Thanks!

@hamilton hamilton merged commit 26d194a into mozilla-rally:master Jan 7, 2021
@hamilton hamilton deleted the only-needed-fonts branch January 7, 2021 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do we need to package all the fonts in public/fonts?
2 participants
@hamilton @Dexterp37