Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-7301 [Swiftlint] Remove 1 closure_body_length violation from MainMenuMiddleware.swift and decrease threshold #23830

Merged
merged 19 commits into from
Dec 20, 2024
Merged

Refactor FXIOS-7301 [Swiftlint] Remove 1 closure_body_length violation from MainMenuMiddleware.swift and decrease threshold #23830

merged 19 commits into from
Dec 20, 2024

Conversation

ionixjunior
Copy link
Contributor

@ionixjunior ionixjunior commented Dec 18, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

This PR removes 1 closure_body_length violation from the MainMenuMiddleware.swift file. Also, this PR decrease the warning and error threshold to 71.

Before this PR, this class spans 87 lines in mainMenuProvider property, and now spans 43 lines. If we want to reach the default warning threshold, we need to improve this implementation.

This PR is part of a series of PRs described here #16442 (comment) and here #16442 (comment).

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@ionixjunior
Decrease warning and error threshold
578aeff
@ionixjunior
Extract the action type logic to a new function
9c18c00
@ionixjunior
Use the new function on handle action type action
c01a8b2
@ionixjunior
Rename function
d5a99a1
@ionixjunior
Extract the tap show details view logic to a new function
837e969
@ionixjunior
Use the new function to handle tap show details view action
3e7b175
@ionixjunior
Extract the tap toggle user agent logic to a new function
e0326e8
@ionixjunior
Use the new function to handle tap toggle user agent action
5fdf909
@ionixjunior
Extract the show reader mode logic to a new function
d044db9
@ionixjunior
Use the new function to handle show reader mode action
fbde777
@ionixjunior
Extract the did instantiate view logic to a new function
3e4fc58
@ionixjunior
Use the new function to handle did instantiate view action
de0b2df
@ionixjunior
Extract the view did load logic to a new function
a4fe22d
@ionixjunior
Use the new function to handle view did load action
e1768ed
@ionixjunior
Extract the tap toggle night mode logic to a new function
c23d59f
@ionixjunior
Use the new function to handle tap toggle night mode action
9a90a3a
@ionixjunior
Extract the tap back to main menu logic to a new function
317f2f6
@ionixjunior
Use the new function to handle tap back to main menu action
bc02a86
@ionixjunior ionixjunior requested a review from a team as a code owner December 18, 2024 00:14
@lmarceau lmarceau changed the title Refactor FXIOS-7301 - Remove 1 closure_body_length violation from MainMenuMiddleware.swift and decrease threshold Refactor FXIOS-7301 [Swiftlint] Remove 1 closure_body_length violation from MainMenuMiddleware.swift and decrease threshold Dec 18, 2024
FilippoZazzeroni
FilippoZazzeroni approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.81%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 32.04

File Coverage
MainMenuMiddleware.swift 39.32% ⚠️

Generated by 🚫 Danger Swift against 3b1aae7

@FilippoZazzeroni FilippoZazzeroni merged commit 92d4d6c into mozilla-mobile:main Dec 20, 2024
13 checks passed
@ionixjunior ionixjunior deleted the issue_16442_part_XXXVIII branch December 23, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilippoZazzeroni FilippoZazzeroni FilippoZazzeroni approved these changes

@issammani issammani Awaiting requested review from issammani issammani is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ionixjunior @mobiletest-ci-bot @FilippoZazzeroni