Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build FXIOS-8134 [v123] Add a test to catch Taskgraph generation fail… #18125

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Build FXIOS-8134 [v123] Add a test to catch Taskgraph generation fail… #18125

merged 1 commit into from
Jan 15, 2024

Conversation

ahal
Copy link
Contributor

@ahal ahal commented Jan 12, 2024 •
edited
Loading

…ures

📜 Tickets

Jira ticket
Github issue

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed I updated documentation / comments for complex code and public methods

@ahal ahal self-assigned this Jan 12, 2024
@ahal ahal force-pushed the taskgraph_test branch 4 times, most recently from 315bfa5 to a2460bc Compare January 12, 2024 20:47
@ahal
Copy link
Contributor Author

ahal commented Jan 12, 2024

@isabelrios hi, I'm a bit lost with Bitrise. I believe I joined the Mozilla org ok, but when I click resolve on the task here, it takes me to https://app.bitrise.io/app/6c06d3a40422d10f

I see a bunch of builds there, but not this one (even if I search with my commit message)

@ahal ahal marked this pull request as ready for review January 12, 2024 20:58
@ahal ahal requested a review from a team as a code owner January 12, 2024 20:58
@ahal ahal requested a review from jjSDET January 12, 2024 20:58
@isabelrios
Copy link
Contributor

isabelrios commented Jan 15, 2024 •
edited
Loading

@isabelrios hi, I'm a bit lost with Bitrise. I believe I joined the Mozilla org ok, but when I click resolve on the task here, it takes me to https://app.bitrise.io/app/6c06d3a40422d10f

I see a bunch of builds there, but not this one (even if I search with my commit message)

It is not intuitive, I can show you later today. When you create a PR, the build appears under the Manual builds approval, at the top
imagen
You can to start it from there so that it appears in the list below..

@isabelrios isabelrios merged commit ff05edd into mozilla-mobile:main Jan 15, 2024
7 checks passed
@ahal ahal deleted the taskgraph_test branch January 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelrios isabelrios isabelrios approved these changes

@jjSDET jjSDET Awaiting requested review from jjSDET jjSDET is a code owner automatically assigned from mozilla-mobile/fxios-automation-1

Assignees

@ahal ahal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahal @isabelrios