📜 Tickets

Jira ticket
Github issue

💡 Description

During The Big Merge of 2023, swiftlint.yml was kept in place, but its content modified, which, in theory, is ok.

The first issue was that the Client's call to swiftlint was missing. This part was easy to figure out. However, on running it, it seems that swiftlint doesn't run at the top level, but relative to the path wherein it was called. Experimentation with removing the swiftlint file around revealed that swiftlint, on being enabled in the build, was actually using some default configurations, which, in actually resulted in a ton of errors, due to said relative pathing issue.

By specifying a relative path in the Client's Switlint step, we're back to our original position in our swiftlint journey, with the only warnings being generated by non-swiftlint items.

This has been an learning journey.

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed I updated documentation / comments for complex code and public methods