Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump FXIOS-7109 [v118] Update taskcluster requirements #15794

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Bump FXIOS-7109 [v118] Update taskcluster requirements #15794

merged 1 commit into from
Aug 3, 2023

Conversation

lmarceau
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

The latest taskcluster version is 6.0.0, so updating to that. I was aiming to fix a dependabot issue, but seems that taskcluster didn't update certifi dependency yet. So look like another update will need to be done at another point in time.

I updated using the commande pip-compile --generate-hashes --output-file requirements.txt requirements.in as mentionned in the requirements.txt file.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed I updated documentation / comments for complex code and public methods

@lmarceau lmarceau requested a review from isabelrios July 27, 2023 19:18
@lmarceau lmarceau requested a review from a team as a code owner July 27, 2023 19:18
@lmarceau lmarceau changed the title Bump FXIOS-7109 [v117] Update taskcluster requirements Bump FXIOS-7109 [v118] Update taskcluster requirements Jul 28, 2023
@clarmso
Copy link
Collaborator

clarmso commented Aug 1, 2023

@isabelrios Who would be the best to review changes on taskcluster? I am not familiar with taskcluster.

@isabelrios
Copy link
Contributor

isabelrios commented Aug 2, 2023 •
edited
Loading

@isabelrios Who would be the best to review changes on taskcluster? I am not familiar with taskcluster.

I can take a look at this, we have to make sure that our jobs that use taskcluster are not broken with the update:

  • L10nScreenshots tests
  • PerformanceTests

@isabelrios
Copy link
Contributor

I run taskgraph full in our project with these changes and the tasks are correctly created, I think we are good to go.

2023-08-02 10:47:40,417 - INFO - Loading graph configuration.
2023-08-02 10:47:40,469 - INFO - Using Parameters(id=b1733fc8aab5) (from defaults)
2023-08-02 10:47:40,470 - INFO - Loading kinds
2023-08-02 10:47:40,475 - INFO - Generating full task set
2023-08-02 10:47:40,483 - INFO - Generated 1 tasks for kind build
2023-08-02 10:47:40,498 - INFO - Generated 1 tasks for kind docker-image
2023-08-02 10:47:40,508 - INFO - Generated 16 tasks for kind generate-screenshots
2023-08-02 10:47:40,510 - INFO - Generated 1 tasks for kind performance
2023-08-02 10:47:40,510 - INFO - Generating full task graph
2023-08-02 10:47:40,510 - INFO - Full task graph contains 19 tasks and 34 dependencies
Dumping result with parameters from defaults:
build-docker-image-screenshots
build-screenshots
generate-screenshots-01
generate-screenshots-02
generate-screenshots-03
generate-screenshots-04
generate-screenshots-05
generate-screenshots-06
generate-screenshots-07
generate-screenshots-08
generate-screenshots-09
generate-screenshots-10
generate-screenshots-11
generate-screenshots-12
generate-screenshots-13
generate-screenshots-14
generate-screenshots-15
generate-screenshots-16
performance-tests

@lmarceau lmarceau merged commit 9bfc19e into mozilla-mobile:main Aug 3, 2023
@lmarceau lmarceau deleted the lm/FXIOS-7109-taskcluster-update branch August 3, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelrios isabelrios isabelrios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmarceau @clarmso @isabelrios