This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Switch to groovy in buildSrc #12329
Merged
Switch to groovy in buildSrc #12329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mcomella from talking to him about buildSrc and kotlin |
boek
approved these changes
Jul 22, 2020
|
@mcomella Is this ok to land? |
|
I don't think there are enough details on the methodology in the a-c bug to draw conclusions that this change has a positive performance impact. However, the change has only a minor impact on developers so I'm not too concerned about it and I don't have time to investigate further so it seems fine to land to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AC this change saved us 13 seconds of build time.