Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and tag VPN links #2075

Merged
merged 2 commits into from
Mar 23, 2021
Merged

fix and tag VPN links #2075

merged 2 commits into from
Mar 23, 2021

Conversation

groovecoder
Copy link
Member

No description provided.

@groovecoder
Copy link
Member Author

@maxxcrawford I can't seem to fix this lack of spacing between the "like" and "Mozilla VPN" link ?

image

@@ -237,7 +237,7 @@ const articleCopy = {
"Use unique, strong passwords for every account",
"Use a password manager to remember all your passwords for you",
"Turn on two-factor authentication for an extra layer of security",
"Use a VPN (Virtual Private Network) when using public Wi-Fi",
"Use a VPN (like <a target='_blank' href='https://vpn.mozilla.org/?utm_source=monitor.firefox.com&utm_medium=referral&utm_campaign=monitor-security-tips'> Mozilla VPN</a>) when using public Wi-Fi",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this has a space before " Mozilla VPN", which will cause a semi-awkward, stray underline when hovering over a link.

@maxxcrawford
Copy link
Contributor

@maxxcrawford I can't seem to fix this lack of spacing between the "like" and "Mozilla VPN" link ?

image

I'm not seeing this issue:

Chrome (Stable/89):
image

Firefox (Nightly/89.0a1):
image

template-helpers/articles.js Outdated Show resolved Hide resolved
Co-authored-by: Maxx Crawford <maxx.crawford@gmail.com>
@groovecoder
Copy link
Member Author

Thanks. Fixed.

@groovecoder groovecoder merged commit 84317fc into main Mar 23, 2021
@groovecoder groovecoder deleted the tweak-vpn-links branch March 23, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants