Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor db/utils #247

Closed
groovecoder opened this issue Aug 2, 2018 · 1 comment
Closed

Refactor db/utils #247

groovecoder opened this issue Aug 2, 2018 · 1 comment

Comments

@groovecoder
Copy link
Member

Now that we’re down to a single DB table, I want to refactor the DB layer code. Most of db/utils.js is gone now, and the remaining functions are for the email_hashes table that we’re still using.

Refactor db/utils.js and db/models/emailhash.js into a new db/models/subscriber.js model & table, clean up the knex migrations to match.
@groovecoder groovecoder changed the title Refactor db/utils into db/models/subscriber Refactor db/utils Aug 2, 2018
@groovecoder
Copy link
Member Author

Okay, I'm changing this to just refactor db/utils.js, because I'm finding it easier to drop Objection altogether and use knex directly.

It also drops 6 extra dependencies! 🎉

groovecoder added a commit that referenced this issue Aug 2, 2018
@groovecoder
for #247: use shorthand syntax for knex queries
d7fdc7f
groovecoder added a commit that referenced this issue Aug 3, 2018
@groovecoder
for #247: rename "db" to "DB"
6066fec
groovecoder added a commit that referenced this issue Aug 3, 2018
@groovecoder
for #247: rename "db" to "DB"
3c32120
groovecoder added a commit that referenced this issue Aug 6, 2018
@groovecoder
Merge pull request #248 from mozilla/db-refactor-247
069ea0b 
fix #247: refactor db/utils to db/db and just knex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@groovecoder