Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send all breach alerts to X" set but got email on secondary email anyway #1348

Closed
nhnt11 opened this issue Nov 11, 2019 · 1 comment
Closed

Send all breach alerts to X" set but got email on secondary email anyway #1348

nhnt11 opened this issue Nov 11, 2019 · 1 comment
Labels
defect Issue describes a defect that negatively impacts use. feature-email feature-fxa

Comments

@nhnt11
Copy link
Contributor

nhnt11 commented Nov 11, 2019 •
edited
Loading

This issue was originally filed on BMO. The STR below have not been verified.

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

In Firefox Monitor preferences, I set "Send all breach alerts to X" to my primary email address. I then added a secondary email address, and verified the secondary email

Actual results:

I received a breach alert on the secondary email.

Expected results:

Should have received the breach alert on the primary email, cause that is what I configured in preferences!
@groovecoder
Copy link
Member

I was ~able to reproduce this bug:

  1. Go to http://localhost:6060/user/preferences
  2. Allow session to time out
  3. Select "Send all breach alerts to X"
  4. The request silently fails 😢 so the user has no indication that the breach alerts are still being sent to the breached address.

@lesleyjanenorton do we have UI to display back-end errors during the dashboard/preferences operations?

I found another bug related to sending breach alerts to primary addresses ...

  1. Set all breach alerts to send to primary@address.com
  2. Trigger a breach for secondary@address.com
  3. Receive breach alert email at primary@address.com

Expected results:
Headline should say "secondary@address.com appeared in a new data breach"

Actual results:
Headline says "primary@address.com appeared in a new data breach"

I've sent a PR with a fix, AND with a new script for sending test breach alerts! No more curl commands!

@groovecoder groovecoder added feature-email feature-fxa defect Issue describes a defect that negatively impacts use. labels Nov 11, 2019
groovecoder added a commit that referenced this issue Nov 12, 2019
@groovecoder
Merge pull request #1350 from mozilla/fix-secondary-email-alerts-1348
ec19345 
fix #1348: send secondary email alerts with proper headline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect Issue describes a defect that negatively impacts use. feature-email feature-fxa
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@groovecoder @nhnt11