New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure any rendered HTML from HIBP is sanitized before rendering #113

Closed

pdehaan opened this issue May 22, 2018 · 1 comment

Collaborator

pdehaan commented May 22, 2018

Per #112 (review)

Currently [in the PR], we're rendering out the meta.Description from HIBP:

{{! TODO: make sure meta.Description is a safe string so we can use triple-{{{ }}
{{{ meta.Description }}}

The text was updated successfully, but these errors were encountered:

pdehaan mentioned this issue

update hibp to use real range API #112

Merged

Collaborator Author

pdehaan commented May 23, 2018

Actually... this is a line item in #55 security checklist, so you're probably free to close it:

JavaScript applications should use DOMPurify

groovecoder added a commit that referenced this issue


          fix #113: use dompurify on HIBP description

88a7c1a

groovecoder closed this as completed in

c50e4b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment