Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document new feature for setting planner termination conditions in OMPL #427

Merged
merged 2 commits into from
Nov 21, 2019
Merged

document new feature for setting planner termination conditions in OMPL #427

merged 2 commits into from
Nov 21, 2019

Conversation

mamoll
Copy link
Contributor

@mamoll mamoll commented Nov 20, 2019

Description

This should be merged after moveit/moveit#1695 gets merged.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@mamoll mamoll mentioned this pull request Nov 20, 2019
Merged
6 tasks
@mamoll
Copy link
Contributor Author

mamoll commented Nov 20, 2019

The CostConvergence[solutionsWindow,epsilon] planner termination condition is not available unless OMPL 1.5.0 / OMPL master branch is used. Is there an easy to conditionally include text based on OMPL version number or just add a note that it is only available if OMPL is compiled from source or when using ROS Noetic?

@davetcoleman
Copy link
Member

The tutorials are built separate from the other moveit code, so won't really know what version OMPL is in use. But as long as we keep this change in master and just add a small note about OMPL version, that should be enough.

@rhaschke rhaschke merged commit 7eaf62d into master Nov 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the pr-terminationcondition branch November 21, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

@davetcoleman davetcoleman davetcoleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mamoll @davetcoleman @rhaschke