Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ikfast: replace ambiguous isnans in generated source #619

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

gavanderhoorn
Copy link
Member

Alternative fix for #584.

I'd like this to replace #586.

@gavanderhoorn
Copy link
Member Author

@v4hn: sorry for taking so long.

@v4hn
Copy link
Contributor

v4hn commented Sep 26, 2017

Wow, deep Regex magic at work :-)

Thank you for taking care of this and I'm sorry it took me this long to respond after pushing you to do it.
IROS still keeps me pretty much busy.

@hartmanndennis could you please check if this works for you? You were the OP for this issue and I don't have a workspace around that I could use to test.

@gavanderhoorn
Copy link
Member Author

re: testing: yes, I've been thinking how to easily / properly test this, but the only thing I could come up with would be to generate an actual IKFast solver and make the test(s) run the create_ikfast_moveit_plugin.py script with the appropriate arguments.

I'll see if I can set that up - and how much additional time it adds to the - already long - build / test time of moveit.

@hartmanndennis
Copy link
Contributor

This solution works. I also checked updating multiple times and it correctly only adds std:: once.
But it seems to me that create_ikfast_moveit_plugin.py has a bug since the change that moved it to the moveit_kinematics package. See #620

@gavanderhoorn
Copy link
Member Author

re: multiple times: yes, that is what the negative lookbehind was for.

thanks for testing.

@v4hn
Copy link
Contributor

v4hn commented Sep 26, 2017

merging. Thanks for the feedback @hartmanndennis .
Thanks for fixing it @gavanderhoorn :)

@v4hn v4hn merged commit a822455 into moveit:indigo-devel Sep 26, 2017
@gavanderhoorn gavanderhoorn deleted the ikfast_replace_isnans branch October 18, 2017 13:05
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
Co-authored-by: Tyler Weaver <tyler@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants