correct "simplify widget handling" #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24adb47.
Jntzko
force-pushed
the
fixMotionPlanningDisplay
branch
from
cf8fc0f to
04c5ca0
Compare
v4hn
requested changes
Feb 27, 2017
| @@ -55,6 +56,7 @@ | |||
| #endif | |||
|
|
|||
| #include <moveit_msgs/DisplayTrajectory.h> | |||
| #include <QDockWidget> | |||
There was a problem hiding this comment.
I believe this is not needed, because now you use rviz::PanelDockWidget instead, right?
Could you please remove it from the request?
There was a problem hiding this comment.
You're right, I removed it.
This improves on commit: e677d8cc790d91f427606c23717954015f207ef7 With the previous solution, hiding the docking area when the motion planning panel is part of it disabled the whole display including the motion planning *scene* that is displayed in the main window. So instead of relying on the setAssociatedWidget mechanism, we have to implement the wanted behavior ourselves.
Jntzko
force-pushed
the
fixMotionPlanningDisplay
branch
from
04c5ca0 to
f16c1ea
Compare
v4hn
approved these changes
Feb 28, 2017
|
Thank you. |
6 tasks
130s
pushed a commit
that referenced
this pull request
Mar 7, 2017
This was referenced Feb 11, 2018
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from the pull request #442 leads to an error.
Hiding the docking area when the motion planning panel is part of it disabled the whole display including the motion planning scene that is displayed in the main window.
So instead of relying on the setAssociatedWidget mechanism, we have to implement the wanted behavior ourselves.