Fix catkin_lint #2120
Merged
Fix catkin_lint #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henningkayser
approved these changes
May 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
=======================================
Coverage 57.80% 57.80%
=======================================
Files 328 328
Lines 25700 25700
=======================================
+ Hits 14855 14856 +1
+ Misses 10845 10844 -1
Continue to review full report at Codecov.
|
|
@rhaschke argues for not having to add this dependency in cmake: #2116 (comment) . |
rhaschke
reviewed
May 29, 2020
| @@ -81,6 +81,7 @@ catkin_package( | |||
| moveit_ros_robot_interaction | |||
| object_recognition_msgs | |||
| roscpp | |||
| rviz | |||
There was a problem hiding this comment.
This one is correct, because we indeed include rviz headers in our headers.
JafarAbdi
force-pushed
the
pr-fix_catkin_lint
branch
from
02612ff to
2bed7c3
Compare
rhaschke
approved these changes
May 29, 2020
v4hn
reviewed
May 29, 2020
rhaschke
approved these changes
May 29, 2020
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
May 29, 2020
catkin_lint became a little stricter in checking...
davetcoleman
pushed a commit
to davetcoleman/moveit
that referenced
this pull request
Jun 2, 2020
catkin_lint became a little stricter in checking...
davetcoleman
pushed a commit
to davetcoleman/moveit
that referenced
this pull request
Jun 2, 2020
catkin_lint became a little stricter in checking...
pradeepr-roboticist
pushed a commit
to pradeepr-roboticist/moveit
that referenced
this pull request
Jun 3, 2020
catkin_lint became a little stricter in checking...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As you can see, right now the master branch is failing due to catkin_lint -- example: https://travis-ci.org/github/ros-planning/moveit/jobs/692499448
Checklist