Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added demo_gazebo.launch (#1051) #1231

Merged

Conversation

davetcoleman
Copy link
Member

Cherry pick from Kinetic: #1051 (comment)

@mohmadAyman please review

* add transmission elements to the urdf to simulate controllers using gazebo_ros_control

* add demo_gazebo to launch gazebo at the same time as rviz

* add getjointhradwareinterface function

*  add gazebo_ros as an optional dep in SA

* move sensors_3d.yaml to templates dir in SA, add comments, replace  size_t by std::size_t
@davetcoleman davetcoleman mentioned this pull request Nov 26, 2018
6 tasks
Copy link
Contributor

@mayman99 mayman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I still don't have melodic so I can't test run it rn.
btw I've finally got the SA to work as plugin based, that was on an old branch I'll have to clean the code and update the base, it took time but its happening 😄

@davetcoleman davetcoleman merged commit c990011 into moveit:melodic-devel Dec 3, 2018
@davetcoleman davetcoleman deleted the melodic-transmission-gazebo branch December 3, 2018 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants