[Move-package] Enable bytecode as dependencies #865
Conversation
rahxephon89
force-pushed
the
bytecode-compilation-aptos-main
branch
4 times, most recently
from
a6cd3f0 to
5788f3c
Compare
rahxephon89
force-pushed
the
bytecode-compilation-aptos-main
branch
2 times, most recently
from
f0f6c1a to
d866bf8
Compare
rahxephon89
changed the title
rahxephon89
force-pushed
the
bytecode-compilation-aptos-main
branch
from
d866bf8 to
f4b8833
Compare
| // Remove bytecode files | ||
| deps.retain(|p| !p.path.as_str().ends_with(MOVE_COMPILED_EXTENSION)); |
There was a problem hiding this comment.
Could you explain the reasoning to remove bytecode files from deps?
Targets means that the compiler is intended to produce bytecode modules for those sources files, which I'm not sure makes sense here
There was a problem hiding this comment.
At this point, deps may already contain paths to mv files that are used as external dependencies, which will cause panic later when calling the function parse_file.
There was a problem hiding this comment.
So the "interface" files have been generated at this point right? Would it make sense to just remove the .mv files from deps after generating the source files for them?
There was a problem hiding this comment.
Thanks for the advice Todd! I moved the code to here. I am wondering whether it makes more sense?
rahxephon89
force-pushed
the
bytecode-compilation-aptos-main
branch
2 times, most recently
from
c0dd054 to
4d24d3d
Compare
rahxephon89
force-pushed
the
bytecode-compilation-aptos-main
branch
from
4d24d3d to
b9c5539
Compare
Motivation
Re-enable the feature to use bytecode as dependencies when compiling Move programs.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Add later