This repository has been archived by the owner on Apr 15, 2020. It is now read-only.
Add option to allow use of graphicsmagick instead of imagemagick #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be awesome to get this rolled into the project! Is there anything I can do to help this process? |
mooz
added a commit
that referenced
this pull request
Jan 11, 2016
Add option to allow use of graphicsmagick instead of imagemagick
|
Thanks for the patch and sorry for the late response (I've been busy recently). I've added your account to collaborators of the project ;) |
|
oh wow thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added mocha to the devdependencies and added the npm script for running the tests.
And fixed the failing test in master!
We are already using graphicsmagick and the gm node module in other places, would be great to not have to install a second utility.