Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolySub: really prevent cutoff from exceeding Nyquist freq #29

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

synthetiv
Copy link
Contributor

Fixes #28. Just adds some parens and a - 1, to make sure the cutoff is always below Nyquist.

@tehn tehn requested a review from catfact April 19, 2020 21:19
Copy link
Contributor

@catfact catfact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@catfact catfact merged commit 764eb82 into monome:master Apr 26, 2020
@catfact
Copy link
Contributor

catfact commented Apr 26, 2020

hey, thanks! (and sorry for lag on this, i wasn't watching the we repo)

@synthetiv synthetiv deleted the synthetiv/polysub-nyquist branch April 26, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PolySub filter cutoff sometimes exceeds Nyquist frequency
2 participants