[Fix] import standart\jsonArray files, alert on successful import #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er objects processing, alert on successful import
|
Happy Hack! Thank you for your contribution :) |
dozoisch
reviewed
Oct 19, 2021
lib/routes/collection.js
Outdated
| @@ -3,6 +3,7 @@ | |||
| const _ = require('lodash'); | |||
| const Bluebird = require('bluebird'); | |||
| const os = require('os'); | |||
| const EJSON = require('mongodb-extended-json'); | |||
There was a problem hiding this comment.
It looks like this package is no longer maintained
https://www.npmjs.com/package/mongodb-extended-json
and that it's now included in the BSON package directly as of version 4, which is the version we're using. Can you take a look at that?
There was a problem hiding this comment.
I've updated the import, still works fine.
dozoisch
approved these changes
Oct 26, 2021
|
No, lastest version is 1.0.0-alpha.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import fixed, EJSON provides correct ObjectId, Date and other entities processing. Added alert with inserted documents number on success.
Based on #761, #653, maybe closes other import related issues.
Happy Hacktoberfest!