Changed the way scripts are loaded into page #312
Merged
+571
−21,055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use node_modules to load scripts. This makes it a lot easier to update
them
- use node_modules for css files. (Take them from distributions and copy
them in build directory. This includes all codemirror themese
- removed prettify (doesn't seem to be used anywhwere)
- removed all assets that are now in webpack build
- added webpack to build scripts
- each page has his own bundle
- two common: codemirror & vendors.
- vendors has jquery & bootstrap
- codemirror has codemirror!
- jquery, bootstrap & codemirror are now node_modules
- build is done on install for production.
- npm run start-dev builds & runs for staging
- npm start now start in production
wulfsolter
approved these changes
Feb 19, 2017
|
@wulfsolter trying to :)! Next step is tests for views. Want to make sure that we can move fast without breaking things |
ryodocx
pushed a commit
to ryodocx/mongo-express
that referenced
this pull request
Mar 18, 2019
Changed the way scripts are loaded into page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use node_modules to load scripts. This makes it a lot easier to update
them
use node_modules for css files. (Take them from distributions and copy
them in build directory. This includes all codemirror themese
removed prettify (doesn't seem to be used anywhwere)
removed all assets that are now in webpack build
added webpack to build scripts
build is done on install for production.
npm run start-dev builds & runs for staging
npm start now start in production
Would love to get some feedback on this! @wulfsolter @heartnetkung