Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change duration.toIsoString to duration.toISOString #1759

Merged
merged 1 commit into from
Jul 8, 2014
Merged

Change duration.toIsoString to duration.toISOString #1759

merged 1 commit into from
Jul 8, 2014

Conversation

icambron
Copy link
Member

@icambron icambron commented Jul 3, 2014

Fix for #1752. Added a deprecation warning to the old toIsoString

@icambron icambron changed the title Change duration.toIsoString to duration.toISOString. Closes #1752 Change duration.toIsoString to duration.toISOString. Jul 3, 2014
@icambron icambron changed the title Change duration.toIsoString to duration.toISOString. Change duration.toIsoString to duration.toISOString Jul 3, 2014
@ichernev
Copy link
Contributor

ichernev commented Jul 8, 2014

Looks good!

ichernev added a commit that referenced this pull request Jul 8, 2014
@ichernev
Merge pull request #1759 from icambron/iso_vs_ISO
3128c63 
Change duration.toIsoString to duration.toISOString

@changelog
@section deprecation
@description rename duration.toIsoString to duration.toISOString
@ichernev ichernev merged commit 3128c63 into moment:develop Jul 8, 2014
@kaelig kaelig mentioned this pull request Aug 6, 2014
Merged
@kkirsche kkirsche mentioned this pull request Feb 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icambron @ichernev