Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min max redo #1637

Merged
merged 6 commits into from
May 7, 2014
Merged

Min max redo #1637

merged 6 commits into from
May 7, 2014
+69 −31

Conversation

ichernev
Copy link
Contributor

@ichernev ichernev commented May 1, 2014

PR for #1548

icambron
icambron reviewed May 5, 2014
View reviewed changes
moment.js
moment.min = function () {
var args = [].slice.call(arguments, 0);

if (args.length === 1 && isArray(args[0])) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably fold this is into _pickBy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@icambron
Copy link
Member

icambron commented May 7, 2014

Ah, so good to have this fixed.

icambron added a commit that referenced this pull request May 7, 2014
@icambron
Merge pull request #1637 from ichernev/min-max-redo
1d0c198 
Min max redo
@icambron icambron merged commit 1d0c198 into moment:develop May 7, 2014
@ichernev ichernev deleted the min-max-redo branch May 10, 2014 16:05
@theurere theurere mentioned this pull request Jul 1, 2014
Merged
@kkirsche kkirsche mentioned this pull request Feb 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichernev @icambron