Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simple expressions #9238

Merged
merged 24 commits into from
Jul 2, 2021
Merged

feat: simple expressions #9238

merged 24 commits into from
Jul 2, 2021

Conversation

fdlk
Copy link
Contributor

@fdlk fdlk commented May 5, 2021 •
edited by tommydeboer
Loading

  • scheduled jobs
  • half hoge buttons. css dingetje?
  • docs
  • 9.0
  • nog meer docs, zie comments Tommy
  • attribuut bugje oude forms
  • metadata checks in importer verzachten, zodat expressies mogen wijzigen -> feat: allow update of entity types through EMX #9264
  • magma script in voorbeeldjes metadata editor frontend
    • fixen
    • migration step
  • expressions library:
    • compare dates
    • current year functie
    • age at certain date
    • regex flags
  • emx voorbeeldfiles
  • test plan data

Checklist

  • Functionality works & meets specifications
  • Code reviewed
  • Code unit/integration/system tested
  • [9] Migration step added in case of breaking change
  • User documentation updated
  • [NA] (If you have changed REST API interface) view-swagger.ftl updated
  • Test plan template updated
  • Clean commits
  • Added Feature/Fix to release notes

Fixes #9248

@fdlk fdlk force-pushed the feat/simple-expressions branch from 93c5978 to d9368f9 Compare May 27, 2021 23:32
@tommydeboer tommydeboer self-assigned this Jun 1, 2021
@fdlk fdlk force-pushed the feat/simple-expressions branch 5 times, most recently from c82ad9e to c901404 Compare June 3, 2021 10:36
@fdlk fdlk force-pushed the feat/simple-expressions branch from c901404 to 8d4c5c8 Compare June 3, 2021 10:58
@tommydeboer tommydeboer self-requested a review June 3, 2021 11:20
@fdlk fdlk force-pushed the feat/simple-expressions branch from 0d98254 to 01cf082 Compare June 7, 2021 11:15
@fdlk fdlk force-pushed the feat/simple-expressions branch from 01cf082 to d5e6e3f Compare June 7, 2021 11:55
tommydeboer
tommydeboer requested changes Jun 8, 2021
View reviewed changes
Copy link
Collaborator

@tommydeboer tommydeboer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MagmaScript is still referenced in the docs:

✅ Resolved

@fdlk fdlk marked this pull request as ready for review June 10, 2021 22:00
@fdlk fdlk mentioned this pull request Jun 14, 2021
Merged
7 tasks
@tommydeboer
Copy link
Collaborator

image
The examples in the Metadata Manager still show Magma

@fdlk fdlk force-pushed the feat/simple-expressions branch from 81570c9 to 57c2211 Compare June 17, 2021 09:51
@fdlk
Copy link
Contributor Author

fdlk commented Jun 17, 2021 •
edited
Loading

Schermafbeelding 2021-06-17 om 20 35 18

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.2% 72.2% Coverage
0.0% 0.0% Duplication

@tommydeboer tommydeboer merged commit 1b54335 into molgenis:master Jul 2, 2021
@fdlk fdlk deleted the feat/simple-expressions branch July 2, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommydeboer tommydeboer tommydeboer approved these changes

Assignees

@tommydeboer tommydeboer

Labels
branch:master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Questionnaire example not working
2 participants
@fdlk @tommydeboer