-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#62] Add the initial version of Brunch & Webpack guides #63
Conversation
@codeithuman I'd love to go over this with you tomorrow. I have some questions on the brunch configuration in particular. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment, looks great!
guides/webpack.md
Outdated
options: { | ||
name: '[name].[ext]', | ||
outputPath: 'images/', | ||
publicPath: '../' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might add a note saying your name:
, outputPath:
and publicPath:
may need to be updated based on your final asset folder structure.
@zberkom Our other open source project include .md files in a |
Is this ready to ship? |
Yeah, I think it is. I plan on adding to it, but it's a good start.
…On Wed, Jul 5, 2017 at 10:58 PM, Jamon Holmgren ***@***.***> wrote:
Is this ready to ship?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGweMXuEKdgJm3VW0BbgdkeBSX1_aBHCks5sLHdsgaJpZM4OI0gU>
.
--
*Zachary Berkompas*
Software Engineer ∞ Infinite Red, Inc. <http://infinite.red/>
(360) 521-7728 <+13605217728>
|
README.md
Outdated
} | ||
``` | ||
Using Webpack? [Checkout the Webpack guide](/docs/guides/webpack.md) | ||
Using Brunch? [Checkout the Brunch guide](/docs/guides/brunch.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"check out" is two words when used as a verb. :)
README.md
Outdated
} | ||
``` | ||
Using Webpack? [Checkout the Webpack guide](/docs/guides/webpack.md) | ||
Using Brunch? [Checkout the Brunch guide](/docs/guides/brunch.md) | ||
|
||
### Test CSS Instalation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix "Installation" spelling while you're at it
## Webpack Configuration for Torch | ||
|
||
Below is an example `webpack.config.js` (version 3.0.0) that imports Torch javascript, css, | ||
fonts, & images correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe note: "We recommend you use yarn
for best results rather than npm
."
@@ -0,0 +1,39 @@ | |||
## Brunch Configuration for Torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe note: "We recommend you use yarn for best results rather than npm."
This is a rough version so feel free to criticize freely 😄.