Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#62] Add the initial version of Brunch & Webpack guides #63

Merged
merged 4 commits into from
Jul 18, 2017

Conversation

zberkom
Copy link
Contributor

@zberkom zberkom commented Jun 29, 2017

This is a rough version so feel free to criticize freely 😄.

@zberkom zberkom requested a review from codeithuman June 29, 2017 04:47
@zberkom
Copy link
Contributor Author

zberkom commented Jun 29, 2017

@codeithuman I'd love to go over this with you tomorrow. I have some questions on the brunch configuration in particular.

Copy link
Contributor

@codeithuman codeithuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment, looks great!

options: {
name: '[name].[ext]',
outputPath: 'images/',
publicPath: '../'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might add a note saying your name:, outputPath: and publicPath: may need to be updated based on your final asset folder structure.

@codeithuman
Copy link
Contributor

@zberkom Our other open source project include .md files in a docs folder in the root directory. I'd place the .md files in root>docs>guides to keep it consistent.

@jamonholmgren
Copy link
Contributor

Is this ready to ship?

@zberkom
Copy link
Contributor Author

zberkom commented Jul 6, 2017 via email

README.md Outdated
}
```
Using Webpack? [Checkout the Webpack guide](/docs/guides/webpack.md)
Using Brunch? [Checkout the Brunch guide](/docs/guides/brunch.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"check out" is two words when used as a verb. :)

README.md Outdated
}
```
Using Webpack? [Checkout the Webpack guide](/docs/guides/webpack.md)
Using Brunch? [Checkout the Brunch guide](/docs/guides/brunch.md)

### Test CSS Instalation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix "Installation" spelling while you're at it

## Webpack Configuration for Torch

Below is an example `webpack.config.js` (version 3.0.0) that imports Torch javascript, css,
fonts, & images correctly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe note: "We recommend you use yarn for best results rather than npm."

@@ -0,0 +1,39 @@
## Brunch Configuration for Torch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe note: "We recommend you use yarn for best results rather than npm."

@zberkom zberkom merged commit 81c8459 into master Jul 18, 2017
@zberkom zberkom deleted the feature/62/brunch-and-webpack-guides branch July 18, 2017 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants