Reorganize repo as a lib with example, rather than an umbrella app #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original configuration, this project was an umbrella app, with one app being the torch lib itself, and the other app being the example. This proved problemmatic for a number of reason, so this rather sizeable commit reorganizes the repo so that the torch lib is at the top level, and the example app is in the apps dir.
zberkom
approved these changes
Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large PR that completely reorganizes the project so that it is no longer an umbrella app. Instead, it is a simple mix app, with the torch library code at the top level, and the example app places in an
appssubdirectory.The
exampleapp points to torch using thepathoption inmix.exsso it can be continue to be used for development and testing of torch itself.The motivation for this change was initially described in #24, but there's now a further pressing need, as the new version of hex (0.14.0) apparently no longer supports libraries created as apps within umbrella apps. Specifically, the extra path configurations used within umbrella apps seems to cause compile errors when integrated with another app.
For all these reasons, I believe this project architecture is the best way forward.