Fix visibility of the Install button in packages grid #16675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting, code style, optimization changes only
Create explicit 'isInstalled' prop separate from the 'installed' date field to more reliably and clearly indicate a packages installable state
Remove unneeded redefinition of uninstall record prop (it's already passed in using the same value from the calling fn)
Change order of uninstall signature to simplify (providing default val for params prop)
|
I tested installing a minimal package that has separate "Install" and "Update" sections in resolvers and validators. I can confirm that in 3.1.0, using "Reinstall" works as it should with respect to resolvers and validators. For new packages, the "Install" section executes, for new versions that update the package, the "Update" section executes. So, using Reinstall will be a reliable workaround until this fix is released. |
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/extjs-problems-on-newly-installed-site/8247/2 |
opengeek
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a new prop to provide a boolean indicator of a package's installed state. The prop utilizes the recently-introduced date formatter's
isEmptymethod, which more comprehensively determines whether theinstalledfield contains a meaningful value.Note that this new prop still relies on a derived value. It would be much better IMO at some future point to persist this state in a new database field rather than basing it off of a date value.
Why is it needed?
Install button is currently missing in the grid.
How to test
Download, install, and uninstall a few packages to verify the install button appears as expected.
Related issue(s)/PR(s)
Resolves #16672