Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to Playwright CI docs #2021

Merged
merged 2 commits into from
Aug 10, 2022
Merged

docs: update link to Playwright CI docs #2021

merged 2 commits into from
Aug 10, 2022

Conversation

enqueue
Copy link
Contributor

@enqueue enqueue commented Aug 9, 2022

The link to the Playwright manual was broken.

The use of the microsoft/playwright-github-action is discouraged (You don't need this GitHub Action). The recommended way is to install dependencies using the Playwright CLI commands.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

⚠️ No Changeset found

Latest commit: ce116af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Actually, we no longer use this deprecated action since #1587.
Updated the PR to also use the correct link to Playwright CI documentation.

@web-padawan web-padawan merged commit 0bad5cd into modernweb-dev:master Aug 10, 2022
koddsson pushed a commit to koddsson/web that referenced this pull request Mar 23, 2023
koddsson pushed a commit to koddsson/web that referenced this pull request Apr 20, 2023
koddsson pushed a commit to koddsson/web that referenced this pull request Apr 24, 2023
koddsson pushed a commit to koddsson/web that referenced this pull request Jun 7, 2023
koddsson pushed a commit to koddsson/web that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants