Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashset perf test #2758

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

The hashset perf test that was added in #2677 currently doesn't run because the perf regressions use the cargo-kani mode, so tests need to be in a cargo package form.

I verified locally that the test is now included:

test [cargo-kani-test] perf/hashset/expected ... ok

Resolved issues:

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? N/A

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner September 12, 2023 19:43
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhassan-aws zhassan-aws enabled auto-merge (squash) September 12, 2023 19:59
@zhassan-aws zhassan-aws merged commit 7136495 into model-checking:main Sep 12, 2023
@zhassan-aws zhassan-aws deleted the hashset-perf branch September 12, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants