Compile harnesses with the same set of stubs together #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve Kani compiler to compile harnesses that have exact the same set of stubs in a single Rust compiler session.
feliperodri
requested changes
Jun 12, 2023
tests/script-based-pre/stubbing_compiler_sessions/check_compiler_sessions.sh
Outdated
Show resolved
Hide resolved
tests/script-based-pre/stubbing_compiler_sessions/check_compiler_sessions.sh
Outdated
Show resolved
Hide resolved
feliperodri
approved these changes
Jun 13, 2023
zhassan-aws
approved these changes
Jun 13, 2023
tests/script-based-pre/stubbing_compiler_sessions/check_compiler_sessions.sh
Outdated
Show resolved
Hide resolved
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Improve Kani compiler to compile harnesses that have exact the same set of stubs in a single Rust compiler session. This reduces the number of times we compile a crate when it has multiple harnesses use the same set of stubs.
Resolved issues:
Resolves #2494
Related RFC:
Optional #1809
Call-outs:
We could optimize further by looking at the transitive rules of the stubbing logic and by looking at matching subset of stubs for cases where some stubs are unreachable.
Testing:
How is this change tested? New test
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.