Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove atty dependency #2580

Closed
celinval opened this issue Jul 4, 2023 · 0 comments · Fixed by #2581
Closed

Remove atty dependency #2580

celinval opened this issue Jul 4, 2023 · 0 comments · Fixed by #2581
Assignees
@karkhaz
Labels
[C] Bug This is a bug. Something isn't working.

Comments

@celinval
Copy link
Contributor

celinval commented Jul 4, 2023

The "cargo audit" workflow is currently failing due to a the following advisory: https://rustsec.org/advisories/RUSTSEC-2021-0145

We can probably just use the new standard library API: std::io::IsTerminal - Stable since Rust 1.70.0
@celinval celinval added the [C] Bug This is a bug. Something isn't working. label Jul 4, 2023
karkhaz added a commit to karkhaz/kani that referenced this issue Jul 4, 2023
@karkhaz
Use std::io::IsTerminal instead of atty
e55e0b6 
This is in response to a security advisory stating that atty is
unmaintained and recommending to use std::io::IsTerminal.

https://rustsec.org/advisories/RUSTSEC-2021-0145

This fixes model-checking#2580.
karkhaz added a commit to karkhaz/kani that referenced this issue Jul 4, 2023
@karkhaz
Use std::io::IsTerminal instead of atty
ca86c9c 
This is in response to a security advisory stating that atty is
unmaintained and recommending to use std::io::IsTerminal.

https://rustsec.org/advisories/RUSTSEC-2021-0145

This fixes model-checking#2580.
@karkhaz karkhaz mentioned this issue Jul 4, 2023
Merged
4 tasks
karkhaz added a commit that referenced this issue Jul 5, 2023
@karkhaz
Remove atty and tracing-tree, update hermit-abi (#2581)
b35b4e6 
This removes dependency on atty, and tracing-tree (which depends on atty). This is in response to this security advisory:

https://rustsec.org/advisories/RUSTSEC-2021-0145

atty is removed by switching to std::io::IsTerminal. tracing-tree is removed by replacing HierarchicalLayer with a regular tracing_subscriber::fmt::layer that directs to stderr.

The PR also updates hermit-abi to 0.3.2 from 0.3.1, in response to 0.3.1 being yanked.

This PR resolves #2580.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karkhaz karkhaz

Labels
[C] Bug This is a bug. Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove atty and tracing-tree, update hermit-abi karkhaz/kani
2 participants
@karkhaz @celinval