Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Fixed the pom packaging bug #854

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Fixed the pom packaging bug #854

merged 1 commit into from
Jan 13, 2020

Conversation

mockitoguy
Copy link
Member

Fixes #847 - users can configure pom in the build.file so our logic cannot blindly add XML nodes - we need to check for existence of nodes.

This is a wider problem - this PR fixes one instance - see the TODO in the code.

Happy New Year everybody :-)

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #854 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #854      +/-   ##
============================================
+ Coverage     76.85%   76.85%   +<.01%     
- Complexity     1229     1230       +1     
============================================
  Files           219      219              
  Lines          4467     4468       +1     
  Branches        334      335       +1     
============================================
+ Hits           3433     3434       +1     
  Misses          922      922              
  Partials        112      112
Impacted Files Coverage Δ Complexity Δ
...rg/shipkit/internal/gradle/util/PomCustomizer.java 75.8% <100%> (+0.39%) 11 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ab193...80fa1ef. Read the comment docs.

@mockitoguy mockitoguy merged commit bc1eb92 into master Jan 13, 2020
@mockitoguy mockitoguy deleted the fix-847 branch January 13, 2020 00:23
@mockitoguy
Copy link
Member Author

Thank you for review!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POM exception when using shipkit with jar archiveClassifier
2 participants